tidb: fix string() panic if txn is nil #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Add a test please. |
|
PTAL |
|
LGTM |
1 similar comment
|
LGTM |
ngaut
added a commit
that referenced
this pull request
Sep 8, 2015
tidb: fix string() panic if txn is nil
YuJuncen
pushed a commit
to YuJuncen/tidb
that referenced
this pull request
Apr 23, 2021
* backup: run backup first and then checksum Running backup and checksum concurrently slows down the total time Signed-off-by: Neil Shen <[email protected]> * restore: run restore first then checksum Signed-off-by: Neil Shen <[email protected]> * *: unify checksum computation Signed-off-by: Neil Shen <[email protected]> * backup: log total backup checksum time cost Signed-off-by: Neil Shen <[email protected]> * checksum: use low priority Signed-off-by: Neil Shen <[email protected]> * backup: remove duplicated range schema build function Signed-off-by: Neil Shen <[email protected]>
okJiang
pushed a commit
to okJiang/tidb
that referenced
this pull request
Oct 19, 2021
* add CsvNullValue Cli usage * Update cmd/dumpling/main.go Co-Authored-By: kennytm <[email protected]> Co-authored-by: kennytm <[email protected]>
Defined2014
pushed a commit
to Defined2014/tidb
that referenced
this pull request
Apr 13, 2022
iosmanthus
pushed a commit
to iosmanthus/tidb
that referenced
this pull request
Oct 31, 2022
* fix gcutil.GetGCSafePoint Signed-off-by: David <[email protected]>
iosmanthus
pushed a commit
to iosmanthus/tidb
that referenced
this pull request
May 11, 2023
* gcutil: fixed GetGCSafePoint (pingcap#58) * fix gcutil.GetGCSafePoint Signed-off-by: David <[email protected]> * make check Signed-off-by: David <[email protected]> --------- Signed-off-by: David <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.